Skip to content

Fix space-within-parens with option 0 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2020
Merged

Fix space-within-parens with option 0 #332

merged 2 commits into from
Feb 15, 2020

Conversation

MatthiasKunnen
Copy link
Contributor

PR Checklist

Overview

If the requirement is 0 spaces, the result will be never.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great edge case find 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3aede48 into typescript-eslint:master Feb 15, 2020
@MatthiasKunnen MatthiasKunnen deleted the space-within-parens-zero-spaces branch February 19, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

space-within-parens converts 0 spaces incorrectly
2 participants
@MatthiasKunnen @JoshuaKGoldberg